Stricter JSHint rules #482
Conversation
|
Only thing broken is testrunner.htm. I'll try to fix this soon-ish. |
|
Fixed. |
|
Thanks @XhmikosR ! I'm still debating whether some of these should wait for a JSCS cleanup (need to wait for the next cut for some indenting bugs in 1.3.0) |
|
I wouldn't wait for JSCS at this point since JSCS is for style only.... |
|
Also, keep in mind that it's hard to keep rebasing this branch so we better get this in. It's also blocking me from making other changes like sorting the destination build dir etc. |
src/rules/known-properties.js
Outdated
There was a problem hiding this comment.
This should be removed entirely since it looks like it was related to some previously removed code in e91d7ef
There was a problem hiding this comment.
Yeah, you are right, I'll remove it.
|
@XhmikosR I get the frustration from rebasing, and I know this isn't the first time you've heard this, but smaller PRs are easier to review and merge. |
|
I can break the patches, but they all will conflict so I'll need to open one PR at a time. That's fine as long as the PRs are merged sort of fast :) |
|
@nschonni: now this PR only has the strict changes. |
|
Now, one thing I was wondering about, should we call |
|
bump |
2 participants
The test failures I was getting after switching to
===and!==were actually caused by wrong checks in the beginning.Example:
event.value == "none"whenvalueisn't a string.For the
quotmarkI went with double quotes since that's what was already being used more often.